Feature: resource default config#3135
Closed
bpolaszek wants to merge 2 commits into
Closed
Conversation
alanpoulain
reviewed
Oct 2, 2019
alanpoulain
reviewed
Oct 2, 2019
alanpoulain
reviewed
Oct 2, 2019
alanpoulain
reviewed
Oct 2, 2019
Contributor
Author
|
As discussed offline with @dunglas, several issues may be raised with this approach:
I'll open another PR to reflect those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
defaultsconfiguration as an implementation of #3099.Dummy implementation
As discussed offline with @alanpoulain and @dunglas, the implementation has been thought to be as dummy as possible, i.e. any configurable property or attribute in
@ApiResource(and even future ones) can be configured on a default basis.This means this configuration is perfectly correct for all resources:
But this one too:
Which means unconfigured
@ApiResources will have the same description. That doesn't make sense, but we assume it's up to the developer, not the implementation, to decide what makes sense and what doesn't.Short-hand operations configuration aren't supported yet
This short-hand configuration:
is currently normalized in a private method from another
ResourceMetadataFactorywith a higher priority. What are your recommendations to standardize it?